Fix missing group proposal #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Oct 14, 2024
There was a problem hiding this comment.
Thanks for taking a look at this @ydaveluy. I can verify that the fix works, but I'll need a bit more time to investigate whether it breaks anything - adding elements to the set was supposed to break infinite loops in the completion calculation, but I'm not able to reproduce those anymore.
msujew
force-pushed
the
fix-missing-group-proposal
branch
from
5278ce4 to
727c480
Compare
msujew
force-pushed
the
fix-missing-group-proposal
branch
from
727c480 to
8c55dd0
Compare
msujew
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
@ydaveluy Sorry for the long review time. I wasn't entirely sure whether completely removing the branch will lead to stack overflows. Instead I changed the behavior a bit to only add the element to the set in case it is not a Group. This seems to pass the newly added test as well.
This looks good to me. Thanks for looking into it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #1677.
Add an additional test case and implement the fix.